Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an awkward prop type option #16

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Remove an awkward prop type option #16

merged 1 commit into from
Dec 21, 2023

Conversation

plumdog
Copy link
Contributor

@plumdog plumdog commented Dec 21, 2023

This does break BC, as datadogApiKeySecret no longer accepts a secretsmanager.ISecret, but this is trivially replaced with an ecs.Secret.fromSecretsManager(...).

@plumdog plumdog merged commit 4d72ba8 into main Dec 21, 2023
1 check passed
@plumdog plumdog deleted the remove-some-awkward-props branch December 21, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@plumdog