Implement transactions in v3 API #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
reviewed
Jul 21, 2023
test/v3_test.dart
Outdated
| transformer: StreamChannelTransformer( | ||
| StreamTransformer.fromHandlers( | ||
| handleData: (data, sink) { | ||
| print('[IN]: $data'); |
There was a problem hiding this comment.
Do we want these print statements in the test?
There was a problem hiding this comment.
No, my bad 🤦 They're left over from me debugging tests.
There was a problem hiding this comment.
Similar to what the docker_process package is doing, I've replaced them with a logger that is disabled by default. That way, to debug failing tests, it's easy to enable the logs to see where it's going wrong.
If you think that code shouldn't be in tests I can remove it as well.
isoos
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
runandrunTxmethods in the v3 draft.I think much of the confusion related to exceptions in the old API comes from the fact that not awaiting statements was supported. Given that this is rarely a good idea, we can just forbid this in the v3 API and always rethrow the original exception.
To implement this, I've lifted the
_operationLockfrom the connection class into a shared session class. This allows transactions to use their own_operationLockwhile keeping the one from the connection locked the entire time.