-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary encoder for numeric datatype #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, but I'd like to see the RegExp values to be extracted as top-level fields. There is a chance to optimize the string concatenations a bit, but I don't mind the current state, it doesn't seem to have too much runtime benefit to do it right away.
I've resolved the merge conflicts in the CHANGELOG, thanks for doing this! I think combined with your other PR, this is worth to get released right away :) |
Pubilshed as 2.4.0 |
@isoos Big thanks for reviewing contributions, and for maintaining and providing such projects! |
It seems that the implementation is quite heavy, but when I looked into other repositories, they also have a bulk of code: