Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add substitutionValues for useSimpleQueryProtocol #62

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Add substitutionValues for useSimpleQueryProtocol #62

merged 2 commits into from
Sep 14, 2022

Conversation

osaxma
Copy link
Contributor

@osaxma osaxma commented Sep 14, 2022

substitutionValues was ignored for useSimpleQueryProtocol -- my bad.

@isoos isoos merged commit 80333ec into isoos:master Sep 14, 2022
@isoos
Copy link
Owner

isoos commented Sep 14, 2022

Thanks!
Should I publish it as is, or do you want to add something else too?

@osaxma
Copy link
Contributor Author

osaxma commented Sep 14, 2022

No, I got nothing else to add. Thanks!

@osaxma osaxma deleted the add_substitute_values_to_simple_query branch September 14, 2022 12:47
@isoos
Copy link
Owner

isoos commented Sep 14, 2022

published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isoos isoos isoos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osaxma @isoos