Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SASL / SCRAM-SHA-256 Authentication #6
SASL / SCRAM-SHA-256 Authentication #6
Changes from 10 commits
d2d38aa
b62d2a8
f0ebbda
48aeeee
dba3cd2
5248abe
754f1a4
2d22dad
0a8379a
ba68358
5a23b85
7e0a608
ea87688
3a85e06
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no reason to make this mutable on the public API, and maybe, there is no need to expose it at all.
AuthenticationScheme _authenticationScheme = AuthenticationScheme.SCRAM_SHA_256;
createAuthenticator
, the only caller point will have access to the private field.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it depends: I don't know if there are actually auth mechanisms, where the user can decide which to use (e.g. md5 vs. plain text (?)). If not, then the
authenticationScheme
variable can be ditched totally and only work as param as the server communicates with the client which auth mechanism to choose.You're always welcomed to change the code in my PRs, no need to ask if you're sure about something :)