[Streaming Replication 7th] Replication Mode Messages Handling #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps letting the MessageFramer to be aganostic to ReplicationMode
tests were added as well
isoos
reviewed
Sep 10, 2022
| LogicalReplicationMessage parseLogicalReplicationMessage(Uint8List bytesList) { | ||
| /// Tries to check if the [XLogDataMessage.bytes] is a [LogicalReplicationMessage] | ||
| /// If so, it'll return | ||
| XLogDataMessage tryParseLogicalReplicationMessage(XLogDataMessage message) { |
There was a problem hiding this comment.
In my experience tryX usually returns T?: either T if successful, or null if not. This method seems to be better places on the XLogDataMessage (either directly or through an extension method) and named cast or castToLogicalReplication, especially if those message have a LogicalReplicationMessage interface or superclass. wdyt?
There was a problem hiding this comment.
Good catch and I totally agree with you.
I added XLogDataMessage.parse and made tryParseLogicalReplicationMessage returns LogicalReplicationMessage?. Let me know if it looks better.
isoos
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes/additions:
I'll submit a final PR after this to update changelogs, version, and readme.