[Streaming Replication - 3rd] Add LSN type and time conversion to and from ms-since-Y2K #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
osaxma
commented
Sep 9, 2022
osaxma
commented
- Adds Log Sequence Number type -- used widely by the Streaming Replication Messages
- Adds conversion form and to microseconds since 2000-01-01 (the baseline time used by PostgreSQL in replication messages).
osaxma
changed the title
isoos
requested changes
Sep 9, 2022
lib/src/time_converters.dart
Outdated
| @@ -0,0 +1,12 @@ | |||
| const _microsecFromUnixEpochToY2K = 946684800 * 1000000; | |||
There was a problem hiding this comment.
Nitpicking: This seems to be a magic number. Can we get the same value from DateTime.utc([...?]).microsecondsSinceEpoch ?
There was a problem hiding this comment.
Yeah I don't know what I was thinking.. fixed!
lib/src/types.dart
Outdated
| } | ||
|
|
||
| static int _parseLSNString(String string) { | ||
| int upperhalf; |
lib/src/types.dart
Outdated
| if (halves.length != 2) { | ||
| throw Exception('Invalid LSN String was given ($string)'); | ||
| } | ||
| upperhalf = int.parse(halves[0], radix: 16) << 32; |
There was a problem hiding this comment.
final upperhalf =...
same with lowerhalf
lib/src/types.dart
Outdated
| int lowerhalf; | ||
| final halves = string.split('/'); | ||
| if (halves.length != 2) { | ||
| throw Exception('Invalid LSN String was given ($string)'); |
There was a problem hiding this comment.
Make it FormatException or maybe PostgreSQLException.
test/types_test.dart
Outdated
| // These two numbers are equal but in different formats | ||
| // | ||
| // see: https://www.postgresql.org/docs/current/datatype-pg-lsn.html | ||
| const _lsnStringSample = '16/B374D848'; |
There was a problem hiding this comment.
I think these could be inlined in the test, with the above comment at the level of the test().
isoos
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.