Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for boolean array fields #41

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

slightfoot
Copy link

@slightfoot slightfoot commented Jun 18, 2022

Added support for boolean arrays in binary and text form.

@slightfoot slightfoot force-pushed the feature/boolean_arrays branch from 21dff8e to cf78fb9 Compare June 18, 2022 22:23
@isoos
Copy link
Owner

isoos commented Jun 19, 2022

Looks good, but the newly added test failed on CI:
PostgreSQLSeverity.error 42704: type "_boolean" does not exist

Could you take a look why that happens?

@slightfoot slightfoot force-pushed the feature/boolean_arrays branch from cf78fb9 to 25c3894 Compare June 20, 2022 17:45
@slightfoot
Copy link
Author

@isoos that's what I get for renaming something before pushing. I changed it back to _bool and its working. I also verified the array type alias with my local pgAdmin tool to check the naming. Indeed _boolean does not work and _bool does.

The tests should now pass in CI.

@isoos isoos merged commit 19661f0 into isoos:master Jun 20, 2022
@isoos
Copy link
Owner

isoos commented Jun 20, 2022

Published as 2.4.5, thank you!

@slightfoot slightfoot deleted the feature/boolean_arrays branch August 18, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants