Support for additional types (varchar, point, integerArray, textArray, doubleArray, jsonArray) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
requested changes
Mar 24, 2021
There was a problem hiding this comment.
Most of it looks good to me, but I'd like to see a few changes here and there.
Two more things:
- Please also update changelog with the description of changes.
- Please, if possible, add tests to
query_test.dart, e.g. creating a table with these types, inserting one row, and reading it back.
…-dart into add-missing-types-pr # Conflicts: # pubspec.yaml
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the encoding and decoding of some additional types, especially some array types. I also changed the json type to jsonb and implemented a new json type, to be consistent with the postgres types.
I added the types to additional maps / switch statements that I could find, but I'm not sure I got everything. I would also need help writing tests for the new types.