-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builtin time, geometric and most range types #294
Add builtin time, geometric and most range types #294
Conversation
Thanks for the PR! I'll have time for review in the coming days, but a quick look:
|
I ran I bumped the version and added a note to changelog. I ran The most tricky part of the code were the range types. I think I covered most edge cases in Next time I will add things in smaller chunks. |
I just upgraded my Dart version to
Could you make the necessary fix in |
Good catch! Pushed a fix to the git repo, you may rebase to it (or just adapt the same change). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! I have mostly nits and a few rename requests, plus a few clarification questions.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
==========================================
- Coverage 85.75% 85.68% -0.08%
==========================================
Files 25 27 +2
Lines 2261 2662 +401
==========================================
+ Hits 1939 2281 +342
- Misses 322 381 +59 ☔ View full report in Codecov by Sentry. |
Is there anything you want me to do regarding the Codecov report? All the issues flagged regarding the |
Thanks for the updates! I'll merge this now, and play with it locally, maybe refactor a bit here and there. I am planning to publish the new version with this later today or maybe tomorrow at latest. |
I added some builtin types as discussed in issue #293.
This is the first time I contribute to a project on Github, so I'm more than happy to fix any issues you might see with pull request.
Once is merged, I would add
numrange
, but I wanted to ask if it wouldn't be better to change the currentnumeric
type fromGenericType<Object>(TypeOid.numeric)
that acceptsint
,double
andString
toGenericType<Decimal>(TypeOid.numeric)
using the decimal library (https://pub.dev/packages/decimal).