Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added const for settings classes #267

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

Gerrel
Copy link
Contributor

@Gerrel Gerrel commented Dec 3, 2023

or else prevents me from making const repository classes

@isoos
Copy link
Owner

isoos commented Dec 3, 2023

@Gerrel: I think also the PoolSettings should be set const to keep it consistent. Would you be also able to update the version and add a changelog entry?

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b4d97fb) 85.77% compared to head (ad45168) 85.74%.
Report is 3 commits behind head on master.

Files Patch % Lines
lib/src/messages/client_messages.dart 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   85.77%   85.74%   -0.04%     
==========================================
  Files          25       25              
  Lines        2215     2216       +1     
==========================================
  Hits         1900     1900              
- Misses        315      316       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gerrel
Copy link
Contributor Author

Gerrel commented Dec 4, 2023

Yes, will update it later today.

@isoos
Copy link
Owner

isoos commented Dec 4, 2023

@Gerrel: Thanks for the changes. How urgent this is for you to get it published?

@isoos isoos merged commit 7c94186 into isoos:master Dec 4, 2023
1 check passed
@Gerrel
Copy link
Contributor Author

Gerrel commented Dec 4, 2023

@isoos Take your time ... there is no urgency.

@isoos
Copy link
Owner

isoos commented Dec 5, 2023

published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants