Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/release script #808

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Fix/release script #808

merged 2 commits into from
Mar 3, 2022

Conversation

alexanderleegs
Copy link
Contributor

@alexanderleegs alexanderleegs commented Mar 3, 2022

Problem

Previously, we were using $npm_config_update to specify the variable used in the npm release script - however, there was a conflict with the npm_config variables used to configure npm itself, causing this script to fail to work as intended. To fix this, we prefix the argument with a unique prefix, converting it to isomer_update instead of update.

Relevant docs: https://docs.npmjs.com/cli/v7/using-npm/config#environment-variables

@alexanderleegs alexanderleegs merged commit 6a41093 into develop Mar 3, 2022
@alexanderleegs alexanderleegs deleted the fix/release-script branch March 3, 2022 05:02
@alexanderleegs alexanderleegs mentioned this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants