Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove encoding in homepage and when saving edit contact us #406

Merged
merged 4 commits into from
Apr 13, 2021

Conversation

alexanderleegs
Copy link
Contributor

@alexanderleegs alexanderleegs commented Apr 13, 2021

This PR fixes a bug involving the editing of contact us pages. In line with the recent changes to page encoding on the backend (PR #133), simple page encoding is now performed in the backend, so we were mistakenly encoding contact us pages twice. This has been corrected to send the data as is.

In addition, this PR also shifts the encoding/decoding to the backend. To be reviewed in conjunction with PR #151 on the isomercms-backend repo.

@alexanderleegs alexanderleegs requested a review from gweiying April 13, 2021 02:32
@alexanderleegs alexanderleegs changed the title Fix: remove encoding when saving edit contact us Fix: remove encoding in homepage and when saving edit contact us Apr 13, 2021
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alexanderleegs alexanderleegs merged commit b76fb30 into staging Apr 13, 2021
@alexanderleegs alexanderleegs deleted the fix/remove-encoding-in-edit-contact-us-page branch April 13, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants