Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/handle invalid folders in edit nav bar #392

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

alexanderleegs
Copy link
Contributor

This PR fixes the handling of EditNavBar to handle cases where links specify collections which do not exist. A warning modal has been added to display to the users which items have been deleted:
Screenshot 2021-03-31 at 11 50 08 AM

This PR also fixes a bug in which EditContactUs was decoding already decoded content, in line with our recent changes made in PR #133 on the isomercms backend.

Copy link
Contributor

@kwajiehao kwajiehao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alexanderleegs alexanderleegs merged commit ab21534 into staging Apr 5, 2021
@alexanderleegs alexanderleegs deleted the fix/handle-invalid-folders-in-EditNavBar branch April 5, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants