Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/userId #346

Merged
merged 5 commits into from
Feb 23, 2021
Merged

Feat/userId #346

merged 5 commits into from
Feb 23, 2021

Conversation

gweiying
Copy link
Contributor

@gweiying gweiying commented Feb 18, 2021

This PR adds functionality to display username on the frontend when users are logged in. To be reviewed with #110 on the backend

Edited

Updated to use localStorage for storing username since the cookie authentication token persists beyond a single session.

Screenshot 2021-02-18 at 6 28 09 PM

@gweiying gweiying linked an issue Feb 18, 2021 that may be closed by this pull request
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gweiying
Copy link
Contributor Author

@NatMaeTan have a look at the image above and see if it looks good!

@sarahsalim
Copy link

@gweiying displaying as the githandle looks fine and makes sense too. good thinking :)

@gweiying gweiying merged commit 2faa5d2 into staging Feb 23, 2021
@gweiying gweiying deleted the feat/userId branch February 23, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve and display user identifier on CMS
3 participants