-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/update resource name display and fix misc bugs #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderleegs
changed the title
Fix/update resource name display
Fix/update resource name display and misc bugs
Dec 16, 2020
alexanderleegs
changed the title
Fix/update resource name display and misc bugs
Fix/update resource name display and fix misc bugs
Dec 16, 2020
kwajiehao
suggested changes
Dec 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comments
kwajiehao
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #292. It updates our resource name display in preparation for the resource name migration to rename existing resource files. The title of resources are now prettified, similarly to what is being done for pages. Additionally, we check for the existence of the special string "dollar" followed by any alphanumeric character, as this indicates that the title of the file contains a $ sign. The reason we require this is due to the generation and prettifying of resource file names - the filename will still contain the dollar string, but we would like the display the title on the cms as the user first inputted it.
In addition, the following bugs have been fixed: