Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update resource name display and fix misc bugs #294

Merged
merged 6 commits into from
Dec 16, 2020

Conversation

alexanderleegs
Copy link
Contributor

@alexanderleegs alexanderleegs commented Dec 15, 2020

This PR resolves #292. It updates our resource name display in preparation for the resource name migration to rename existing resource files. The title of resources are now prettified, similarly to what is being done for pages. Additionally, we check for the existence of the special string "dollar" followed by any alphanumeric character, as this indicates that the title of the file contains a $ sign. The reason we require this is due to the generation and prettifying of resource file names - the filename will still contain the dollar string, but we would like the display the title on the cms as the user first inputted it.

In addition, the following bugs have been fixed:

  • A typo in the endpoint being called when deleting folders has been corrected.
  • Previously, we were not distinguishing correctly between new and existing collections, causing an error when we attempted to retrieve collection data for a new collection. A new variable to check for new collections has been added to OverviewCard.
  • The title of the delete warning modal when deleting pages has been corrected.

@alexanderleegs alexanderleegs changed the title Fix/update resource name display Fix/update resource name display and misc bugs Dec 16, 2020
@alexanderleegs alexanderleegs changed the title Fix/update resource name display and misc bugs Fix/update resource name display and fix misc bugs Dec 16, 2020
Copy link
Contributor

@kwajiehao kwajiehao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

src/utils.js Outdated Show resolved Hide resolved
src/components/OverviewCard.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@kwajiehao kwajiehao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderleegs alexanderleegs merged commit 5f45778 into staging Dec 16, 2020
@alexanderleegs alexanderleegs deleted the fix/update-resource-name-display branch December 16, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: $ sign in file title
2 participants