Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add check for PayloadTooLargeError for media #289

Merged

Conversation

alexanderleegs
Copy link
Contributor

@alexanderleegs alexanderleegs commented Dec 9, 2020

This PR adds handling for the PayloadTooLargeError in the MediaSettingsModal. To be reviewed with PR#94 on the isomercms-backend repo. This PR attempts to resolve #226.

Copy link
Contributor

@kwajiehao kwajiehao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderleegs alexanderleegs merged commit 88d16ff into staging Dec 9, 2020
@alexanderleegs alexanderleegs deleted the fix/error-handling-for-large-files-and-images branch December 9, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return warning message if uploaded file/image is too large
2 participants