Feat/warning if unsaved settings #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit saves the original settings configuration as a state variable so that we can compare the current settings fields with the original state to see if any changes were made. This allows us to warn the user if they attempt to navigate away from the page without saving their changes. This commit also removes the `footerSha` attribute from state since it is no longer required after PR #85 on the backend.
This commit introduces a util function i found on stack overflow, https://stackoverflow.com/a/39813128, which deep compares two objects and identifies which attributes have changed.
This commit deep compares the current settings values with the original loaded settings values and displays a warning if the user attempts to navigate away from the page when there are unsaved changes.
This commit modifies the behavior of the Settings layout save handler so that only fields which have been changed are sent in the request. Previously, we would send all state fields, regardless of whether the fields have changed in value. The problem is that this results in wasteful writes to the GitHub repo on the backend. It also leads to slow performance since the writes to the GitHub repo are sequential. Co-authored-by: Jie Hao Kwa <[email protected]>
alexanderleegs
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replica of #285 since we merge-committed into staging instead of squashing and merging, which resulted in a messy history.