Feat/add settings modal to folder card #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwajiehao
suggested changes
Nov 20, 2020
src/components/FolderModal.jsx
Outdated
Comment on lines
48
to
51
| <SaveDeleteButtons | ||
| isDisabled={false} | ||
| hasDeleteButton={false} | ||
| saveCallback={saveHandler} |
There was a problem hiding this comment.
Can we align these to the right?
There was a problem hiding this comment.
Resolved in 583bedc
src/components/FolderModal.jsx
Outdated
Comment on lines
63
to
64
| onProceed: PropTypes.func.isRequired, | ||
| onCancel: PropTypes.func.isRequired, |
There was a problem hiding this comment.
These props are marked as isRequired but aren't defined on the component
There was a problem hiding this comment.
Resolved in 697b4c7
Comment on lines
+80
to
+84
| <DeleteWarningModal | ||
| onCancel={() => setCanShowDeleteWarningModal(false)} | ||
| onDelete={deleteHandler} | ||
| type="folder" | ||
| /> |
There was a problem hiding this comment.
This should have been changed before, but can we also align the delete warning modal's buttons to the right?
There was a problem hiding this comment.
Resolved in 583bedc
|
Note that this PR also fixes the first point in issue #232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a settings dropdown and folder renaming modal to the existing FolderCard. This allows users to rename collections/resource categories, or delete collections/resource categories with all their associated contents.
In addition, this PR is also intended to address the following issues: