-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add layout and functionality for 2d broken link checker #1891
Conversation
src/layouts/LinkReport/components/LinkReportModal/LinkReportModal.tsx
Outdated
Show resolved
Hide resolved
src/layouts/LinkReport/components/LinkReportModal/LinkReportModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot approve since it is a pr i created.
This is ok from my end, all the comments here are just nits. once the nits are resolved, proceed to approve this pr and reember to squah and merge into dev
also moving forward, when creating commits, use commitcitizen for your commits ya
sorry for the delay in review, good work on your first pr!
@@ -236,7 +236,10 @@ export const SiteDashboard = (): JSX.Element => { | |||
<HStack> | |||
<Text textStyle="h4"> | |||
{brokenLinks?.status === "success" && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya seems like this is unchanged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed all nits, proceeding to approve this PR
@hanpuliu-charles todo fill this up ya
Problem
Closes [insert issue #]
This pr implements the 2 level broken link checker interface, moving individual errors on a page into a modal, that overlays over main broken link checker page, which now provides a summary listing the page and number of errors on it in a table.
Solution
Implemented the design here.
Breaking Changes
Features:
Improvements:
Before & After Screenshots
BEFORE:
AFTER:
Tests
npm run tests
)!run e2e
)Not too sure about this. No new test added.