chore: increase contact us field limits #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
approved these changes
May 21, 2024
Comment on lines
+169
to
+179
| const CONTACT_TITLE_MAX_LENGTH = 50 | ||
| const CONTACT_DESCRIPTION_MAX_LENGTH = 400 | ||
|
|
||
| // Locations | ||
| const LOCATION_TITLE_MIN_LENGTH = 1 | ||
| const LOCATION_TITLE_MAX_LENGTH = 30 | ||
| const LOCATION_ADDRESS_MAX_LENGTH = 30 | ||
| const LOCATION_TITLE_MAX_LENGTH = 50 | ||
| const LOCATION_ADDRESS_MAX_LENGTH = 50 | ||
| const LOCATION_OPERATING_DAYS_MIN_LENGTH = 2 | ||
| const LOCATION_OPERATING_DAYS_MAX_LENGTH = 30 | ||
| const LOCATION_OPERATING_DAYS_MAX_LENGTH = 50 | ||
| const LOCATION_OPERATING_HOURS_MIN_LENGTH = 2 | ||
| const LOCATION_OPERATING_HOURS_MAX_LENGTH = 30 | ||
| const LOCATION_OPERATING_HOURS_MAX_LENGTH = 50 |
There was a problem hiding this comment.
ok on the frontend - but are these also coded into our backend?
There was a problem hiding this comment.
No changes required for backend! Backend checks for type of input, but not the length - I think we're okay with this because it's more of a restriction to help users not misuse the fields - but Shaz was showing use cases where the current limit is insufficient
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.