fix(rum): change service tag #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcshzj
approved these changes
Mar 6, 2024
harishv7
reviewed
Mar 6, 2024
| @@ -57,7 +57,7 @@ if (REACT_APP_ENV === "staging" || REACT_APP_ENV === "production") { | |||
| applicationId: REACT_APP_DATADOG_APP_ID, | |||
| clientToken: REACT_APP_DATADOG_CLIENT_TOKEN, | |||
| site: "datadoghq.com", | |||
| service: "isomercms-frontend", | |||
| service: "isomer-infra", | |||
There was a problem hiding this comment.
the name is really confusing tho :/
There was a problem hiding this comment.
other way might involve tearing down and respinning up resources :sadge:
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
our frontend tags the service as
isomercms-frontend; however, with pulumi, we tag all of our resources asisomer-infra. in order to standardise our tagging, will instead useisomer-infraas the converse is more painful.Part of [ISOM-771]
Solution
update rum tag