Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playwright): migrate sites #1805

Merged
merged 1 commit into from
Mar 15, 2024
Merged

feat(playwright): migrate sites #1805

merged 1 commit into from
Mar 15, 2024

Conversation

seaerchin
Copy link
Contributor

Problem

Need to migrate e2e tests over. This PR migrates the sites spec

Closes [insert issue #]

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Features:

  • Details ...

Improvements:

  • Details ...

Bug Fixes:

  • Details ...

Before & After Screenshots

BEFORE:

AFTER:

Tests

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests

Deploy Notes

New environment variables:

  • env var : env var details

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

@seaerchin seaerchin requested a review from a team February 8, 2024 07:19
@seaerchin seaerchin force-pushed the feat/e2e-resourcepage branch from d4be75a to 425aa5b Compare March 15, 2024 11:08
Base automatically changed from feat/e2e-resourcepage to develop March 15, 2024 11:08
@seaerchin seaerchin merged commit e9c7381 into develop Mar 15, 2024
3 of 4 checks passed
@seaerchin seaerchin deleted the feat/e2e-sites branch March 15, 2024 11:09
@seaerchin seaerchin mentioned this pull request Mar 21, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants