Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(herocenteredlayout): make dropdown optional #1556

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix(herocenteredlayout): make dropdown optional #1556

merged 1 commit into from
Oct 3, 2023

Conversation

seaerchin
Copy link
Contributor

Problem

Hero centered layout had no optional chaining for dropdown

Solution

add ?

alexanderleegs
alexanderleegs approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seaerchin seaerchin merged commit 9a051e9 into develop Oct 3, 2023
4 checks passed
@seaerchin seaerchin deleted the fix/dropdown branch October 3, 2023 05:06
@seaerchin seaerchin temporarily deployed to staging October 3, 2023 05:17 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging October 3, 2023 05:18 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @alexanderleegs