Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(announcements): add validation url #1545

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix(announcements): add validation url #1545

merged 1 commit into from
Oct 2, 2023

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Oct 2, 2023 •
edited
Loading

Problem

UI polish, currently weird that
non empty text with empty url leads to error
but
non empty url with empty test leads to NO error

Closes [insert issue #]

Solution

quick validation
Screenshot 2023-10-02 at 9 53 38 AM
Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

@kishore03109 kishore03109 requested a review from a team October 2, 2023 01:57
@kishore03109 kishore03109 temporarily deployed to staging October 2, 2023 02:05 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging October 2, 2023 02:07 — with GitHub Actions Inactive
@kishore03109 kishore03109 merged commit 721ac85 into develop Oct 2, 2023
10 checks passed
@mergify mergify bot deleted the fix/validationAnnouncementLinkUrl branch October 2, 2023 08:06
@seaerchin seaerchin mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshzj dcshzj dcshzj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishore03109 @dcshzj