Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(announcements): sync changes from template #1540

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Sep 29, 2023

Problem

There are changes to the template that have not been synced to the CMS frontend: isomerpages/isomerpages-template#323

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Improvements:

  • Changes to the announcements component preview are now synced with the changes made on the template.

Before & After Screenshots

BEFORE:

Screenshot 2023-09-29 at 1 25 45 PM

AFTER:

Screenshot 2023-09-29 at 1 26 10 PM

Tests

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests
    • Navigate to any site's homepage that can use the new template components
    • Add a new announcements block
    • Verify that the size of the block is now the entire width (AFTER screenshot) instead of being compressed (BEFORE screenshot)

Deploy Notes

None

@dcshzj dcshzj requested a review from a team September 29, 2023 05:27
@dcshzj dcshzj temporarily deployed to staging September 29, 2023 05:35 — with GitHub Actions Inactive
@dcshzj dcshzj temporarily deployed to staging September 29, 2023 05:39 — with GitHub Actions Inactive
@dcshzj dcshzj merged commit 55e0684 into develop Oct 2, 2023
10 checks passed
@mergify mergify bot deleted the chore/sync-announcements-flex branch October 2, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants