Fix/text cards design #1535
Merged
Fix/text cards design #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the design issues raised for text cards. (figma)
The item not addressed is for urls not throwing an error message for being empty - this is an existing issue with our homepage url fields, as they only get validated after the first blur of the field - other instances of this can be seen in infopic/infobar sections and highlights/dropdowns. For now, we will keep the existing behaviour, and will tackle this issue of placeholders and previews for required fields in a future PR.