Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(imports): standardize way to import image assets #1509

Merged
merged 1 commit into from
Sep 20, 2023
Merged

chore(imports): standardize way to import image assets #1509

merged 1 commit into from
Sep 20, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Sep 20, 2023

Problem

The way we import image assets is not standardized.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible

Improvements:

  • The way image assets are imported are now standardized.

Tests

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests

Chore fix, no tests.

Deploy Notes

None

@dcshzj dcshzj requested a review from a team September 20, 2023 08:46
@dcshzj dcshzj temporarily deployed to staging September 20, 2023 08:58 — with GitHub Actions Inactive
@dcshzj dcshzj temporarily deployed to staging September 20, 2023 09:00 — with GitHub Actions Inactive
@dcshzj dcshzj merged commit 4ec6618 into develop Sep 20, 2023
10 checks passed
@mergify mergify bot deleted the chore/standardize-image-imports branch September 20, 2023 09:06
@harishv7 harishv7 mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishore03109 kishore03109 kishore03109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcshzj @kishore03109