fix(contactus): ensure feedback key is present as string #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
approved these changes
Sep 18, 2023
mergify
bot
deleted the
IS-532-contact-us-page-is-not-able-to-save-if-feedback-is-empty-initially
branch
kishore03109
pushed a commit
that referenced
this pull request
Sep 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes IS-532.
Solution
Breaking Changes
Bug Fixes:
feedbackkey needs to be a string, even if it is not required. However, because of the use of_.cloneDeep(), thefeedbackkey will be deleted if the user did not specify a feedback URL, which causes a validation error. This change enforces that thefeedbackkey is always present and sets it to be an empty string if not provided.Tests
npm run tests)!run e2e)_data/footer.ymlfile has a nullfeedbackkey (i.e.feedback:)Deploy Notes
None