Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(homepage): add floating variant #1498

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

seaerchin
Copy link
Contributor

Problem

We have a floating variant of the homepage with extra padding on side. This PR adds that in; this PR also fixes a erroneously placed button, where it should be placed outside of the div to maintain same structure

Solution

  1. use same components for floating homepage but add a div wrapper
  2. shift HeroButton out
  3. shift conditional to not be included in div with className=mb8

Tests

  • select floating variant
  • preview should update
  • select dropdown for hero interaction
  • update options/title
  • change order
  • preview should update
  • do the same for highlight
  • chnage order
  • preview should update
  • repeat on diff screen sizes
  • preview also shud update

@seaerchin seaerchin requested a review from a team September 14, 2023 09:26
@seaerchin seaerchin temporarily deployed to staging September 14, 2023 09:34 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging September 14, 2023 09:38 — with GitHub Actions Inactive
@seaerchin seaerchin force-pushed the feat/homepage-dropdown branch from 452cc38 to d974b59 Compare September 20, 2023 09:02
Base automatically changed from feat/homepage-dropdown to develop September 20, 2023 09:03
@seaerchin seaerchin force-pushed the feat/homepage-floating branch from 90f6a21 to 93a2dcc Compare September 20, 2023 09:16
@seaerchin seaerchin merged commit 3221187 into develop Sep 20, 2023
3 checks passed
@seaerchin seaerchin deleted the feat/homepage-floating branch September 20, 2023 09:16
@seaerchin seaerchin temporarily deployed to staging September 20, 2023 09:29 — with GitHub Actions Inactive
@harishv7 harishv7 mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants