Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(heroimageonlylayout): add dropdown #1494

Merged
merged 2 commits into from
Sep 20, 2023
Merged

feat(heroimageonlylayout): add dropdown #1494

merged 2 commits into from
Sep 20, 2023

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Sep 13, 2023 •
edited
Loading

Problem

Currently our image only layout only has support for highlights and not dropdown. This PR adds it in

Solution

Follow conditionals from template and add the HeroDropdown in to HeroImageOnlyLayout

Tests

  • select image only variant for hero section
  • select dropdown for hero interactions
  • there should be a dropdown in preview
  • update options/title -> preview should also update
  • repeat in diff screen sizes

@seaerchin seaerchin temporarily deployed to staging September 13, 2023 10:33 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging September 13, 2023 10:35 — with GitHub Actions Inactive
@seaerchin seaerchin marked this pull request as ready for review September 14, 2023 07:00
@seaerchin seaerchin requested a review from a team September 14, 2023 07:00
@seaerchin seaerchin temporarily deployed to staging September 14, 2023 07:29 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging September 14, 2023 07:39 — with GitHub Actions Inactive
@seaerchin seaerchin mentioned this pull request Sep 20, 2023
Merged
7 tasks
@seaerchin seaerchin force-pushed the feat/homepage-dropdown branch from 452cc38 to d974b59 Compare September 20, 2023 09:02
Base automatically changed from feat/homepage-dropdown to develop September 20, 2023 09:03
@seaerchin seaerchin force-pushed the feat/add-hero-interactions branch from edb5f56 to 830334f Compare September 20, 2023 09:10
@seaerchin seaerchin merged commit 6640ac5 into develop Sep 20, 2023
3 checks passed
@seaerchin seaerchin deleted the feat/add-hero-interactions branch September 20, 2023 09:11
@seaerchin seaerchin temporarily deployed to staging September 20, 2023 09:25 — with GitHub Actions Inactive
@harishv7 harishv7 mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @alexanderleegs