Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hero-section): adds dropdown #1491

Merged
merged 2 commits into from
Sep 20, 2023
Merged

feat(hero-section): adds dropdown #1491

merged 2 commits into from
Sep 20, 2023

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Sep 13, 2023 •
edited
Loading

Problem

The existing hero section does not have a dropdown. This adds the preview component for the dropdown in.

Solution

Copy paste over the dropdown from the template code (with modification so it can be consumed by react)

Tests

  • Go to the hero section
  • select the side variant
  • select dropdown
  • the options there should be preserved, and the preview should be updated
  • change the dropdown options/title
  • the preview should also update accordingly
  • try this in different view ports (technically we don't support)

@seaerchin seaerchin force-pushed the feat/homepage-dropdown branch from ad891c3 to 12dba17 Compare September 13, 2023 10:04
@seaerchin seaerchin changed the base branch from develop to feat/is-451-preview September 13, 2023 10:04
@seaerchin seaerchin changed the base branch from feat/is-451-preview to feat/homepage-phase-2 September 13, 2023 10:05
@seaerchin seaerchin temporarily deployed to staging September 13, 2023 10:16 — with GitHub Actions Inactive
@seaerchin seaerchin changed the title feat(homepage): adds dropdown feat(hero-section): adds dropdown Sep 14, 2023
@seaerchin seaerchin requested review from alexanderleegs and a team and removed request for alexanderleegs September 14, 2023 06:56
@seaerchin seaerchin marked this pull request as ready for review September 14, 2023 06:56
@seaerchin seaerchin temporarily deployed to staging September 14, 2023 08:12 — with GitHub Actions Inactive
alexanderleegs
alexanderleegs approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seaerchin seaerchin force-pushed the feat/homepage-phase-2 branch 2 times, most recently from 26cc73d to 76c0b19 Compare September 20, 2023 05:14
@seaerchin seaerchin mentioned this pull request Sep 20, 2023
Merged
7 tasks
@seaerchin seaerchin force-pushed the feat/homepage-phase-2 branch from a6b1f7c to a0ea13b Compare September 20, 2023 08:55
Base automatically changed from feat/homepage-phase-2 to develop September 20, 2023 08:57
@seaerchin seaerchin force-pushed the feat/homepage-dropdown branch from 452cc38 to d974b59 Compare September 20, 2023 09:02
@seaerchin seaerchin merged commit ae6b074 into develop Sep 20, 2023
3 checks passed
@seaerchin seaerchin deleted the feat/homepage-dropdown branch September 20, 2023 09:03
@seaerchin seaerchin temporarily deployed to staging September 20, 2023 09:14 — with GitHub Actions Inactive
@harishv7 harishv7 mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @alexanderleegs