fix(herobody): solves empty highlight deafult issue #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcshzj
approved these changes
Sep 13, 2023
alexanderleegs
force-pushed
the
fix/empty-highlights
branch
from
275ec6e to
38eafe9
Compare
alexanderleegs
approved these changes
Sep 13, 2023
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
This was referenced Sep 13, 2023
Merged
kishore03109
pushed a commit
that referenced
this pull request
Sep 20, 2023
* fix(herobody): solves empty highlight deafult issue * fix: add default for hero dropdown * chore: swap intialSectionType selector to follow conditional --------- Co-authored-by: seaerchin <[email protected]> Co-authored-by: Alexander Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously we default to
highlights- however, a bug existed where if you had empty highlights, adding the highlight options would not work on preview (because our preview checks using the!hero.dropdownpropertySolution
update
HeroBodycomponent so that we take aninitialSectionTypeso it fits with how preview does the dropdown/highlightTests