feat(helpers): introduce padding and margin helpers from Tailwind #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderleegs
approved these changes
Sep 13, 2023
|
@dcshzj Pls test with same build scripts as netlify + amplify |
|
Hmm @harishv7 this is different as this PR is for the CMS frontend, which already has been using SCSS. The change with the build scripts are here: isomerpages/isomerpages-template#307 |
|
@dcshzj Got it, what I meant was to test the template PR with the build scripts and ensure everything is good before merging this FE PR |
harishv7
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are not using the padding and margin helpers from SGDS v1.
Solution
Breaking Changes
Features:
Tests
npm run tests)!run e2e)No visible tests, as this only introduces CSS classes that are not used anywhere.
Deploy Notes
None