Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/style nits #1483

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Fix/style nits #1483

merged 7 commits into from
Sep 7, 2023

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Sep 7, 2023 •
edited
Loading

Problem

see here

Closes [insert issue #]

Solution

  1. add consistent spacing of 0.75
  2. add padding on accordion when isNested=true

seaerchin
seaerchin commented Sep 7, 2023
View reviewed changes
src/layouts/components/NavBar/GroupMenuBody.tsx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change made was spacing + remove extra VStack

@seaerchin seaerchin requested a review from a team September 7, 2023 06:25
@seaerchin seaerchin temporarily deployed to staging September 7, 2023 06:37 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging September 7, 2023 06:37 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging September 7, 2023 06:38 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging September 7, 2023 07:10 — with GitHub Actions Inactive
@seaerchin seaerchin merged commit 5470322 into develop Sep 7, 2023
@seaerchin seaerchin deleted the fix/style-nits branch September 7, 2023 07:19
@alexanderleegs alexanderleegs mentioned this pull request Sep 7, 2023
Merged
24 tasks
@seaerchin seaerchin temporarily deployed to staging September 7, 2023 07:31 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @alexanderleegs