Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/0.29.0 #1293

Merged
merged 8 commits into from
Jun 5, 2023
Merged

Release/0.29.0 #1293

merged 8 commits into from
Jun 5, 2023

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Jun 5, 2023 •
edited by alexanderleegs
Loading

v0.29.0

  • Fix: trim whitespace #1291
  • chore(request overivew): don't show diff for files/images #1289
  • Fix: convert email to lower case #1287
  • fix: facebook-pixel expected type #1282
  • fix: add checks to Header component #1286
  • feat(rr): diff view #1158
  • release(0.28.0): merge to dev #1283

Tests for 1158

  • navigate to a email login based repo
  • create a new image
  • create a new file
  • create a new unlinked page
  • create a new page in folder
  • create a new page in a subfolder
  • create a new resource room page
  • repeat the above steps but edit existing items rather than creating
  • request a review
  • pages should be able to be compared, files/images should not
  • resource room page should have human readable name

Tests

  • add a new file
  • add a new image
  • request review request
  • both shud not be clickable

Tests

  • Manually edit a site's facebook-pixel value to be missing
    • Should be able to save any change in settings
  • Manually edit a site's facebook-pixel value to be an empty string
    • Should be able to save any change in settings
  • Manually edit a site's facebook-pixel value to be a string (e.g. facebook-pixel: "12345")
    • Should be able to save any change in settings
  • Should be able to modify facebook-pixel value and have it show up as a string
  • Should be able to delete facebook-pixel and have it show up as empty string

Test

Ensure that the review request button is disabled on all pages when there are >=1 PR in Open/Approved states

seaerchin and others added 8 commits May 25, 2023 16:18
@seaerchin
Merge pull request #1283 from isomerpages/release/v0.28.0
7f1e45c 
release(0.28.0): merge to dev
@seaerchin
feat(rr): diff view (#1158)
4fee2bb 
* feat(requestoverview): add ext link to staging

* chore(requestoverview): remove unused props

* chore(rr): update naming; fixed constants

* build(package): instaleld diff viewer

* feat(diffview): add initial diff view component

* chore(reviewrequestmodal): change ot use heading

* refactor(diffview): refactor to have onclick and use diffview in overview

* feat(useblob): add hook and methods to retrieve blob data from be

* feat(diffview): fetch data from be

* chore(diffview): add error toast

* refactor(diffview): specify fixed marker width

* feat(rr): add type for blob diff

* refactor(diffview): separate diffviewer into own component for stories

* chore(diffview.stories): add diff view stories

* chore(diffview): update type ot use oldvalue/newvalue

* refactor(types): update edited item dto to fit new backend definitio

* refactor(diffview): wip to add ability to show the title

* ref(diffview): add ext link + mocks for stories

* fix(resource card): fix import order
@harishv7
fix: add checks to Header component (#1286)
4cc13e5
@alexanderleegs
fix: facebook-pixel expected type (#1282)
f2a218d 
* fix: facebook-pixel expected type

* Fix: enforce 15 digit number

* Fix: tests

* chore: swap back to string

* Fix: enforce digits only
@alexanderleegs
Fix: convert email to lower case (#1287)
9654926
@seaerchin
chore(request overivew): don't show diff for files/images (#1289)
67bb123
@alexanderleegs
Fix: trim whitespace (#1291)
b68a0b1
@kishore03109
0.29.0
9fd570f
@kishore03109 kishore03109 temporarily deployed to staging June 5, 2023 01:54 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 5, 2023 01:55 — with GitHub Actions Inactive
@kishore03109 kishore03109 mentioned this pull request Jun 5, 2023
Merged
@kishore03109 kishore03109 temporarily deployed to staging June 5, 2023 01:56 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 5, 2023 02:05 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 5, 2023 02:07 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 5, 2023 02:07 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 5, 2023 02:11 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging June 5, 2023 02:11 — with GitHub Actions Inactive
@kishore03109 kishore03109 changed the title 0.29.0 Release/0.29.0 Jun 5, 2023
@kishore03109 kishore03109 merged commit f91a7dd into master Jun 5, 2023
@mergify mergify bot deleted the release/0.29.0 branch June 5, 2023 06:40
@mergify mergify bot requested a review from a team July 5, 2023 06:41
@mergify
Copy link

mergify bot commented Jul 5, 2023

This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers

1 similar comment
@mergify
Copy link

mergify bot commented Aug 4, 2023

This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kishore03109 @alexanderleegs @seaerchin @harishv7