fix: file name in test #1280
fix: file name in test #1280
Conversation
| @@ -2,7 +2,7 @@ import "cypress-file-upload" | |||
| import { Interceptors, TEST_REPO_NAME } from "../fixtures/constants" | |||
|
|
|||
| describe("Files", () => { | |||
| const FILE_TITLE = "singapore" | |||
| const FILE_TITLE = "singapore-file" | |||
There was a problem hiding this comment.
seems liek the same file might be reused across editPage and files, maybe we should consider having both of the specs refer to the same constant by exporting it from our fixtures file?
this means that a change to filename in editPage might cause a downstream failure still
There was a problem hiding this comment.
We actually want the files referred to be different - the tests were made independently of each other, and the issue is that running them sequentially mistakenly referred to the file created in editPage which had a similar title, but was not meant to be the same file
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
1 similar comment
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
Problem
This PR fixes our files test spec - it currently works on its own but not after being run sequentially with edit page, due to the partial match of the file being uploaded in the
editpagespec (singapore-pagesineditpage,singaporeinfiles). The file being searched for infileshas been changed tosingapore-filein order to avoid this overlap.