Is 150 fix feature tour zindex #1252
Conversation
This reverts commit a70eeca.
| zIndex: 2000, // need this for it to be on top of the navbar | ||
| zIndex: 1100, // need this for it to be on top of the navbar |
There was a problem hiding this comment.
@harishv7 in the hotfix PR, there is no change to the zIndex value. In both master and develop branches, the value is 2000 now, why are we changing it to 1100?
There was a problem hiding this comment.
@QiluXie The hotfix PR tried to monitor the state as to if a modal is open or not to determine whether we need to show the feature tour. Bu that is not required.
The way we should handle this is by ensuring modals have a higher zIndex (which means they overlay the feature tour).
At the same time, we need to ensure feature tour has a zIndex which is more than the nav bar and the dashboard/workspace components.
1100 is a sweet spot between the 2 values which will allow feature tour to show up on dashboard/workspace "above" the components and will hide feature tour when a modal is opened (since modals will have a higher zIndex)
There was a problem hiding this comment.
Review Request modal has a zIndex of 1400
There was a problem hiding this comment.
Create new folder modal has 1300
There was a problem hiding this comment.
I tried using 1200, but it didn't work as there are other components with 1200. Hence 1100 was the option I went with
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
1 similar comment
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
Problem
This fix replaces the temporary hotfix for the feature tour conflict with the CMS FE modals (see #1250)
Closes IS-150
Solution
Each component has a different zIndex. The feature tour elements should have a zIndex between that of the elements on CMS dashboard and workspace and the modals. This will prevent users from interacting with the feature tour components when modals are open
Breaking Changes
Testing
Run this locally and ensure you are able to use both the feature tour and modals without conflicts