feat(requestoverview): add link to staging/cms #1161

seaerchin · 2022-11-25T06:22:04Z

corresponding BE PR here

Problem

This adds the link in the review request to either the staging site or the cms site

Closes IS-54

Solution

As the link is constructed on teh BE and returned to the FE, this just displays the link in the correct place

Tests

verified by @kishore03109

src/layouts/ReviewRequest/components/RequestOverview/RequestOverview.tsx

src/mocks/constants.ts

src/layouts/ReviewRequest/components/RequestOverview/RequestOverview.tsx

mergify · 2023-03-21T01:02:13Z

This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers

harishv7 · 2023-03-27T02:58:15Z

src/layouts/ReviewRequest/components/RequestOverview/RequestOverview.tsx

      header: () => (
        <Th borderBottom="1px solid" borderColor="gray.100" w="10rem" />
      ),
      cell: ({ row }) => (
        <HStack spacing="0.25rem">
          {allowEditing && (
-            <Link href="www.google.com">
+            <Link


@seaerchin lgtm, could you add a screenshot of how this looks like on the UI or add steps to test this locally?

there's a story written for this so it should show inside the storybook! can get to it via chromatic below (UI Tests/UI Review)

kishore03109

Chromatic and other CICD builds are failing, may I trouble you to look into them?

harishv7 · 2023-03-29T03:28:25Z

src/mocks/constants.ts

@@ -239,34 +239,30 @@ export const MOCK_SITE_DASHBOARD_INFO: SiteDashboardInfo = {

 export const MOCK_ITEMS: EditedItemProps[] = [
  {
-    type: ["page"],
+    type: "page",


would be nice if this is a TS type rather than string

mergify · 2023-04-29T08:50:58Z

This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers

seaerchin · 2023-05-18T04:28:16Z

!run e2e

cypress · 2023-05-18T05:27:32Z

15 failed tests on run #274 ↗︎

15	109	0	0	0

Details:

feat(requestoverview): add link to staging/cms
Project: isomercms-frontend	Commit: `74fa6dd928`
Status: Failed	Duration: 42:13 💡
Started: May 18, 2023 4:45 AM	Ended: May 18, 2023 5:27 AM

editPage.spec.ts • 1 failed test

View Output Video

Test		Artifacts
editPage.spec > Edit resource page > Edit page (resource) should have correct colour		`Output` `Screenshots` `Video`

files.spec.ts • 7 failed tests

View Output Video

Test		Artifacts
Files > Create file, delete file, edit file settings in Files > Should be able to edit a file		`Output` `Screenshots` `Video`
Files > Create file, delete file, edit file settings in Files > Should not be able to create file with invalid title		`Output` `Screenshots` `Video`
Files > Create file, delete file, edit file settings in Files > Should not be able to edit file and save with invalid title		`Output` `Screenshots` `Video`
Files > Create file, delete file, edit file settings in Files > Should be able to delete file		`Output` `Screenshots` `Video`
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to edit file directory name		`Output` `Screenshots` `Video`
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to delete file directory		`Output` `Screenshots` `Video`
Files > Create file, delete file, edit file settings, and move files in file directories > Should be able to move file to different image album		`Output` `Screenshots` `Video`

folders.spec.ts • 2 failed tests

View Output Video

Test		Artifacts
Folders flow > Create page, delete page, edit page settings in folder > Should not be able to create page with invalid title		`Output` `Screenshots` `Video`
Folders flow > Create page, delete page, edit page settings in subfolder > Should not be able to create page with invalid title		`Output` `Screenshots` `Video`

resourceCategory.spec.ts • 4 failed tests

View Output Video

Test		Artifacts
Resource category page > Resources category page should allow user to create a new resource page of type post		`Output` `Screenshots` `Video`
Resource category page > Resources category page should allow user to create a new resource page of type post		`Output` `Screenshots` `Video`
Resource category page > Resources category page should allow user to create a new resource page of type file		`Output` `Screenshots` `Video`
Resource category page > Resources category page should allow user to create a new resource page of type link		`Output` `Screenshots` `Video`

settings.spec.ts • 1 failed test

View Output Video

Test		Artifacts
Settings page > Should change Logos and have change reflect correctly on save		`Output` `Screenshots` `Video`

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

alexanderleegs

As discussed offline,

We should confirm the behaviour of moving files - currently the change only shows up as a new page instead of both a delete and an add
Confirm behaviour of delete as well - currently it shows up as a file which cannot be viewed on staging/cms (which makes sense, because it's not available anymore), but is this intuitive to users

Approving first because these are not blocking, but it is behaviour that we should confirm with design!

seaerchin · 2023-05-25T06:14:20Z

As discussed offline,

We should confirm the behaviour of moving files - currently the change only shows up as a new page instead of both a delete and an add

Confirm behaviour of delete as well - currently it shows up as a file which cannot be viewed on staging/cms (which makes sense, because it's not available anymore), but is this intuitive to users

Approving first because these are not blocking, but it is behaviour that we should confirm with design!

filed as IS-229

mergify · 2023-06-24T06:17:32Z

This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers

mergify · 2023-07-24T06:18:30Z

This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers

seaerchin had a problem deploying to staging November 25, 2022 06:22 Failure

seaerchin had a problem deploying to staging November 25, 2022 06:34 Failure

seaerchin had a problem deploying to staging December 5, 2022 07:22 Failure

seaerchin had a problem deploying to staging December 5, 2022 07:38 Failure

seaerchin had a problem deploying to staging March 17, 2023 04:14 — with GitHub Actions Failure

seaerchin had a problem deploying to staging March 17, 2023 04:28 — with GitHub Actions Failure

seaerchin changed the title ~~[wip] feat(requestoverview): add ext link to staging~~ feat(requestoverview): add ext link to staging Mar 17, 2023

seaerchin changed the title ~~feat(requestoverview): add ext link to staging~~ feat(requestoverview): add link to staging/cms Mar 17, 2023

seaerchin marked this pull request as ready for review March 17, 2023 05:51

seaerchin requested review from alexanderleegs, harishv7, kishore03109 and QiluXie March 17, 2023 05:51

kishore03109 suggested changes Mar 21, 2023

View reviewed changes

src/layouts/ReviewRequest/components/RequestOverview/RequestOverview.tsx Outdated Show resolved Hide resolved

src/mocks/constants.ts Outdated Show resolved Hide resolved

src/layouts/ReviewRequest/components/RequestOverview/RequestOverview.tsx Outdated Show resolved Hide resolved

mergify bot requested a review from a team March 21, 2023 01:02

seaerchin had a problem deploying to staging March 22, 2023 09:05 — with GitHub Actions Failure

seaerchin had a problem deploying to staging March 22, 2023 09:17 — with GitHub Actions Failure

seaerchin requested a review from kishore03109 March 22, 2023 10:20

seaerchin temporarily deployed to staging March 22, 2023 10:24 — with GitHub Actions Inactive

seaerchin had a problem deploying to staging March 22, 2023 10:37 — with GitHub Actions Failure

harishv7 reviewed Mar 27, 2023

View reviewed changes

seaerchin had a problem deploying to staging March 27, 2023 04:17 — with GitHub Actions Failure

kishore03109 reviewed Mar 27, 2023

View reviewed changes

harishv7 reviewed Mar 29, 2023

View reviewed changes

Base automatically changed from feat/identity-phase-2 to develop March 30, 2023 04:20

mergify bot requested a review from a team April 29, 2023 08:50

seaerchin added 2 commits May 17, 2023 18:14

feat(requestoverview): add ext link to staging

faac062

refactor(requestoverview): change api

0fde7a5

seaerchin added 4 commits May 17, 2023 18:14

refactor(rr): update fo rnew property

e8f4fd0

ref(rr): refactor for new backend shape

275bf3a

chore(requestoverview): remove unused props

b223ea7

chore(rr): update naming; fixed constants

4e2f6e0

seaerchin force-pushed the feat/staging-url branch from 7bf1cf9 to 4e2f6e0 Compare May 17, 2023 10:14

seaerchin had a problem deploying to staging May 17, 2023 10:15 — with GitHub Actions Failure

chore(resourcecard): fixed import order

74fa6dd

seaerchin temporarily deployed to staging May 17, 2023 10:38 — with GitHub Actions Inactive

seaerchin temporarily deployed to staging May 17, 2023 10:51 — with GitHub Actions Inactive

seaerchin requested review from kishore03109 and harishv7 May 18, 2023 04:16

chore(requestoverview): show buttons

c77d58c

seaerchin temporarily deployed to staging May 25, 2023 04:24 — with GitHub Actions Inactive

seaerchin temporarily deployed to staging May 25, 2023 04:37 — with GitHub Actions Inactive

alexanderleegs approved these changes May 25, 2023

View reviewed changes

kishore03109 approved these changes May 25, 2023

View reviewed changes

seaerchin merged commit 807fd60 into develop May 25, 2023

seaerchin deleted the feat/staging-url branch May 25, 2023 05:08

This was referenced May 25, 2023

release(0.28.0): merge to dev #1283

Merged

release(0.28.0): merge to prod #1284

Merged

mergify bot requested a review from a team June 24, 2023 06:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(requestoverview): add link to staging/cms #1161

feat(requestoverview): add link to staging/cms #1161

seaerchin commented Nov 25, 2022 •

edited by kishore03109

Loading

mergify bot commented Mar 21, 2023

harishv7 Mar 27, 2023

seaerchin Mar 27, 2023 •

edited

Loading

kishore03109 left a comment

harishv7 Mar 29, 2023

mergify bot commented Apr 29, 2023

seaerchin commented May 18, 2023

cypress bot commented May 18, 2023

alexanderleegs left a comment

seaerchin commented May 25, 2023 •

edited

Loading

mergify bot commented Jun 24, 2023

mergify bot commented Jul 24, 2023

feat(requestoverview): add link to staging/cms #1161

feat(requestoverview): add link to staging/cms #1161

Conversation

seaerchin commented Nov 25, 2022 • edited by kishore03109 Loading

Problem

Solution

Tests

mergify bot commented Mar 21, 2023

harishv7 Mar 27, 2023

Choose a reason for hiding this comment

seaerchin Mar 27, 2023 • edited Loading

Choose a reason for hiding this comment

kishore03109 left a comment

Choose a reason for hiding this comment

harishv7 Mar 29, 2023

Choose a reason for hiding this comment

mergify bot commented Apr 29, 2023

seaerchin commented May 18, 2023

cypress bot commented May 18, 2023

15 failed tests on run #274 ↗︎

alexanderleegs left a comment

Choose a reason for hiding this comment

seaerchin commented May 25, 2023 • edited Loading

mergify bot commented Jun 24, 2023

mergify bot commented Jul 24, 2023

seaerchin commented Nov 25, 2022 •

edited by kishore03109

Loading

seaerchin Mar 27, 2023 •

edited

Loading

seaerchin commented May 25, 2023 •

edited

Loading