Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(announcements): add help overlay #1521

Merged
merged 1 commit into from
Sep 26, 2023
Merged

feat(announcements): add help overlay #1521

merged 1 commit into from
Sep 26, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Sep 25, 2023

Problem

Closes IS-519.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Features:

  • A new help overlay has been added for the new announcements block.

Before & After Screenshots

AFTER:

Screenshot 2023-09-25 at 6 13 17 PM

Tests

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests
    • Visit any site that can create a new announcements block
    • Verify that the help overlay appears when hovering over the announcements block when adding a new section

Deploy Notes

None

@dcshzj dcshzj requested a review from a team September 25, 2023 10:14
@dcshzj dcshzj temporarily deployed to staging September 25, 2023 10:26 — with GitHub Actions Inactive
@dcshzj dcshzj temporarily deployed to staging September 25, 2023 10:27 — with GitHub Actions Inactive
@seaerchin
Copy link
Contributor

the UI for this looks kinda weird ngl

harishv7
harishv7 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@harishv7 harishv7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just verify if the copy is as per Figma

@dcshzj dcshzj merged commit 2633742 into develop Sep 26, 2023
10 checks passed
@mergify mergify bot deleted the IS-519-announcements-help-overlay branch September 26, 2023 08:22
@kishore03109 kishore03109 mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

@harishv7 harishv7 harishv7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcshzj @seaerchin @harishv7