Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release(v0.45.0): merge to master #1520

Merged
merged 6 commits into from
Sep 25, 2023
Merged

release(v0.45.0): merge to master #1520

merged 6 commits into from
Sep 25, 2023

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Sep 25, 2023 •
edited
Loading

What's Changed

Full Changelog: v0.44.0...v0.45.0

dcshzj and others added 6 commits September 21, 2023 10:32
@dcshzj
fix(chromatic): only do path checking on push (#1513)
4623278 
* fix(chromatic): only do path checking on push

* fix(chromatic): also build on deps changes
@harishv7
Merge pull request #1511 from isomerpages/release/0.44.0
bd48df4 
Release/0.44.0
@kishore03109
feat(template): add ffs as a manual check-in (#1469)
c1f8344 
* feat(template): add ffs as a manual check-in

* feat(template): link do doc for sot
@dcshzj
feat: introduce new help overlay for add section button (#1515)
dcedd36 
* chore(editable): promote to shared component

* feat: introduce new help overlay for add section button

* feat: add storybook for add section button

* chore: remove unneeded story parameter

* chore: update images for text cards and announcements

* fix: adjust story to be more extendible
@kishore03109 @dcshzj
Feat/announcement block (#1497)
c9294c7 
* feat(announcements): add SCSS styles from template

* feat(announcements): introduce preview component

* chore: sync padding and margin helpers

* chore: sync template changes to CMS preview

* feat(announcements): define shape

* feat(validators): announcement validators

* feat(announcement): add announcement block

* feat(edit homepage): add in announcement block

* feat(useDrag): update draggable

* fix(announcement): interface bugs

* fix(announcement): bugs after interface change

* feat(storybook): attempt to get out storybook

* chore(storybook): remove storybook"

The purpose of the commit was to have history of previous attempt vs commenting it in production code

* fix(announcementbody): dont trigger re-render

* fix(announcement): fix bugs wrt shape

normalise datetime

* chore(edit homepage): rm console log

* fi(announcement): on drag bug fix

* chore(edit homepage): rm console.log

* fix(validations): should throw error for empty str

* chore(announcement body): dynamically retrieve max announcement

* chore(homepage): remove redundant check

* chore(edithomepage): remove redundant console.log

* chore(edit homepage): modify this to announcements

* chore(announcement body): rm redundant placeholder

* chore(edithomepage): rm redundant array

* IS-516 link to jira

* chore(useDrag): change verb

* chore(edit homepage): clarity in comment

* fix(announcement): use func to get new datetime

* refactor(validator): change naming

* refactor(announcement): mutate at data level

* fix(announcement body): copy changes

* fix(announcement): copy changes for clarity

* fix(announcement date): show invalid dates

* style(copy): change copy

* fix(announcement): copy changes

* fix(announcement): have 1 announcemnt by default

* build(de): fix failing build

* fix(homapage prevew): rebase errors

* chore(validators): rm console logs

* feat(feature flag): add partial ff for announment

* chore(announcemnt body): rm console log

* chore(announcementBody): comments for clarity

* fix(typing): relax constraint

* chore(announcementbody): rm redundant console.log

* refactor(editHomepage): rm redundant spread

* style(edit homepage): add comments for clarity

* fix(announcements): empty errors bug

* chore(edit homepage): rm redundant func call

* chore(edit homepage): clarify comment

* fix(imports): fix imports after rebase

* fix(imports): issues after rebase

---------

Co-authored-by: Hsu Zhong Jun <[email protected]>
0.45.0
c3cacd5
@mergify
Copy link

mergify bot commented Sep 25, 2023

⚠️ The sha of the head commit of this PR conflicts with #1519. Mergify cannot evaluate rules on this PR. ⚠️

@seaerchin seaerchin temporarily deployed to staging September 25, 2023 08:48 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging September 25, 2023 08:48 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging September 25, 2023 08:49 — with GitHub Actions Inactive
@seaerchin seaerchin temporarily deployed to staging September 25, 2023 08:51 — with GitHub Actions Inactive
@seaerchin seaerchin marked this pull request as ready for review September 25, 2023 09:29
@seaerchin seaerchin changed the title Release/v0.45.0 release(v0.45.0): merge to master Sep 25, 2023
@seaerchin seaerchin requested a review from a team September 25, 2023 09:31
@cypress
Copy link

cypress bot commented Sep 25, 2023

65 failed tests on run #332 ↗︎

65 94 2 18 Flakiness 0

Details:

Release/v0.45.0
Project: isomercms-frontend Commit: c3cacd5b08
Status: Failed Duration: 50:04 💡
Started: Sep 25, 2023 8:54 AM Ended: Sep 25, 2023 9:44 AM
Failed  collaborators.spec.ts • 3 failed tests

View Output Video

Test Artifacts
collaborators flow > Admin adding a collaborator > should be able to add a collaborator Output Screenshots Video
collaborators flow > Admin removing a collaborator > should be able to remove an existing collaborator Output Screenshots Video
collaborators flow > Admin removing a collaborator > should not be able to remove the last site member Output Screenshots Video
Failed  comments.spec.ts • 2 failed tests

View Output Video

Test Artifacts
Comments > admin and collaborator of site > should be able to post comments if you are an admin of the site Output Screenshots Video
Comments > no access rights > should not be able to create comments for a site which one is not a site member Output Screenshots Video
Failed  editPage.spec.ts • 5 failed tests

View Output Video

Test Artifacts
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add untrusted external scripts Output Screenshots Video
editPage.spec > Edit unlinked page > Edit page (unlinked) should not allow users to add inline scripts Output Screenshots Video
editPage.spec > Edit collection page > Edit page (collection) should have correct colour Output Screenshots Video
editPage.spec > Edit collection page > Edit page (collection) should allow user to modify and save content Output Screenshots Video
editPage.spec > Edit resource page > Edit page (resource) should have correct colour Output Screenshots Video
Failed  files.spec.ts • 8 failed tests

View Output Video

Test Artifacts
Files > Create file, delete file, edit file settings in Files > Should be able to edit a file Output Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should not be able to create file with invalid title Output Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should not be able to edit file and save with invalid title Output Screenshots Video
Files > Create file, delete file, edit file settings in Files > Should be able to delete file Output Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to create new file directory Output Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to edit file directory name Output Screenshots Video
Files > Create file directory, delete file directory, edit file directory settings in Files > Should be able to delete file directory Output Screenshots Video
Files > Create file, delete file, edit file settings, and move files in file directories > Should be able to add file to file directory Output Screenshots Video
Failed  folders.spec.ts • 8 failed tests

View Output Video

Test Artifacts
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to create a new sub-folder within a valid folder name with one page Output Screenshots Video
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should not be able to create a new sub-folder with invalid sub-folder name Output Screenshots Video
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to rename a sub-folder Output Screenshots Video
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to delete a sub-folder with a page Output Screenshots Video
Folders flow > Create subfolder, rename subfolder, delete subfolder from Folders > Should be able to delete a sub-folder without page Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to edit existing page details with Tamil title and valid permalink Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in folder > Should be able to delete existing page in folder Output Screenshots Video
Folders flow > Create page, delete page, edit page settings in subfolder > Should be able to edit existing page details with Tamil title and valid permalink Output Screenshots Video

The first 5 failed specs are shown, see all 13 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@seaerchin seaerchin temporarily deployed to staging September 25, 2023 09:53 — with GitHub Actions Inactive
@seaerchin seaerchin merged commit 943df0c into master Sep 25, 2023
28 of 29 checks passed
@mergify mergify bot deleted the release/v0.45.0 branch September 25, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshzj dcshzj dcshzj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seaerchin @dcshzj @harishv7 @kishore03109