feat(feature tour): FF for hero #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishore03109
force-pushed
the
IS-539-Hero-banner-help-overlay
branch
from
690775a to
de72219
Compare
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
commented
Sep 20, 2023
kishore03109
changed the title
seaerchin
force-pushed
the
feat/add-hero-interactions
branch
from
edb5f56 to
830334f
Compare
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
force-pushed
the
IS-539-Hero-banner-help-overlay
branch
from
3659d00 to
8db214a
Compare
kishore03109
commented
Sep 21, 2023
| return ( | ||
| <Box | ||
| padding="1.5rem" | ||
| alignItems="center" | ||
| maxW="100%" | ||
| w="18rem" | ||
| w="20rem" |
There was a problem hiding this comment.
Confirmed wit Design to standardise this already
kishore03109
commented
Sep 21, 2023
| {isLastStep ? ( | ||
| <Button {...primaryProps} title="Done"> | ||
| Done | ||
| Got it |
There was a problem hiding this comment.
Confirmed wit Design to standardise this already
|
!run chromatic |
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
force-pushed
the
IS-539-Hero-banner-help-overlay
branch
from
0aaf863 to
1072914
Compare
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
|
!run chromatic |
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
commented
Sep 22, 2023
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
kishore03109
temporarily deployed
to
staging
GitHub Actions
Inactive
dcshzj
approved these changes
Sep 26, 2023
|
@kishore03109 unable to replicate blocker. Might want to de-prio if this is not happening on staging build |
harishv7
approved these changes
Sep 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are releasing new homepage features. figma link
Closes [insert issue #]
Solution
This PR implements the feature tour + storybooks for this. Feature tour is only shown if feature flag for using the new
HOMEPAGE_TEMPLATESare enabledBreaking Changes
Yes - this PR contains breaking changes
No - this PR is backwards compatible
While API contract for feature tour changed, i preserved the default behaviour of the components.
Screenshots
Screen.Recording.2023-09-20.at.4.37.45.PM.mov
Blocker (potential chrome bug in local machine only)
For some weird reason, the spotlight offsets to create this weird effect. Notice that the tooltip renders properly, but not the spotlight. I did find a related issue here, but the issue was fixed so it seems unlikely to be the cause. NOTE: This was only reproducible in chrome, and only in my local machine. :sadge:
Interestingly, after hot refreshes, the spotlight magically renders to the correct location. I thought this is suggestive of the need to render the spotlight AFTER the render of the Text, but somehow using a useEffect did not solve this :(
Tests
/homepagesite.New dependencies:
dependency: react-intersection-observerWe need to to check if an element is in view. Else feature tour doesnt work, with this error thrown in the console.