-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sl): enhance site launch process to utilise DNS indirection layer #920
feat(sl): enhance site launch process to utilise DNS indirection layer #920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code mostly lgtm, what is our plan looking like moving forward? is it after every launch ops would have to merge the pr?
should we do a if SL success -> merge pr , if SL failure -> delete corresponding repo
? that way we elegantly handle this case + dont have to add additional process to ops?
src/database/migrations/20230824001544-add-indirection-domain.js
Outdated
Show resolved
Hide resolved
@kishore03109 Can I check for the existing redirection repo logic, do/should we also revert the change on site launch failure? |
|
@kishore03109 I am deprioritising the reverting on site launch failure for now as I think the redirection and indirection stuff currently still has a manual component so we can easily catch and recover. Plus, the logic for creating the indirection DNS record also handles the case where the file already exists and will update the values inside. I am thinking in the grander scheme of things, it is very unlikely that the agency will abort a site launch completely due to the technical errors we face when launching sites. Ultimately, we will retry the site launch again in the future and with our existing mechanisms in place to handle a potential existing file, I think reverting back to the original state is not as important. |
@dcshzj ok makes sense, we can go with this flow for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with the code changes, but with anything to do with Infra, I am always abit nervous about the integration.
Before you merge into master, can I trouble you to test the full flow on staging for one test site?
happy to huddle for this, and I think is impt before release as it affects the formsg site launch feature too!
Tested successfully on staging. The records were sent successfully via email: The DNS records were also correctly set up on the isomer-indirections repository (see PR #12 and the Pulumi deployment). |
Problem
Closes IS-498.
Solution
Breaking Changes
Improvements:
launches
table is introduced to store the indirection domains. For backward compatibility, the value in this column can be NULL, but new site launches must have this indirection domain.staging
tomain
, getting someone else to approve it and merging the pull request. The records will be automatically created on Route 53 using Pulumi.Tests
The full site launch process will need to be executed. The tentative plan is to test this with a single site launch happening on the week of 28 August.
Deploy Notes