Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove test for concurrent viewed call #916

Merged

Conversation

alexanderleegs
Copy link
Contributor

Reverts #909 - now that our mutex lock works, the test throws a 423 error instead, and we're unable to replicate the conditions which we were testing on production anymore (prod instead returns 423 for 2 update calls in quick succession)

@alexanderleegs alexanderleegs requested a review from a team August 23, 2023 07:14
Copy link
Contributor

@QiluXie QiluXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderleegs alexanderleegs merged commit d3ff92a into develop Aug 23, 2023
@mergify mergify bot deleted the chore/remove-test-for-concurrent-viewed-calls branch August 23, 2023 08:35
@harishv7 harishv7 mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants