Hotfix IS-489 0.39.1 #913
Merged
Hotfix IS-489 0.39.1 #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishv7
requested review from
kishore03109,
seaerchin,
QiluXie and
alexanderleegs
and removed request for
kishore03109 and
seaerchin
Merged
alexanderleegs
approved these changes
Aug 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the tracked sites are hard-coded and this means a full-redeploy or hotfix releases are required if we want to add more sites along the way. So, we make this into an env var on BE
Closes IS-489
Solution
Add to convict + add new env var
Breaking Changes
New environment variables:
GGS_EXPERIMENTAL_TRACKING_SITES: list of sites for which we are tracking the GitHub API hits