fix: require base64 #904
Merged
fix: require base64 #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced by the upgrade of
base64-js, which previously worked without an explicit import. The affected endpoints are all v1 endpoints, but several api calls on the frontend still use v1 endpoints. We should modify the endpoints being used on the frontend to use v2 endpoints instead, but I've opted for this solution first, since at least 2 of the remaining endpoints do not work with a direct swap (edit nav uses a v1 endpoint that has no equivalent functionality in v2, and edit page uses an outdated v1 endpoint that the v2 endpoint changes the dto of).