Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GGs): implement moving and renaming of files and directories #896

Merged
merged 12 commits into from
Aug 15, 2023
Merged

feat(GGs): implement moving and renaming of files and directories #896

merged 12 commits into from
Aug 15, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Aug 14, 2023 •
edited
Loading

⚠️ Note: This PR will only be rebased after #892 and #894 are merged ⚠️

Problem

Closes IS-402.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible

Features:

  • The moving and renaming of files and directories functionality has been implemented as renameSinglePath or moveFiles.
  • The existing functionality for moving files by deleting then creating has been retained temporarily. The refactoring can be left for later.

Tests

  1. Unit tests

Deploy Notes

None

@dcshzj dcshzj requested a review from a team August 14, 2023 07:08
harishv7
harishv7 reviewed Aug 14, 2023
View reviewed changes
src/routes/v2/authenticatedSites/index.js Show resolved Hide resolved
src/services/db/GitFileSystemService.ts Show resolved Hide resolved
src/services/db/GitFileSystemService.ts Show resolved Hide resolved
src/services/db/GitFileSystemService.ts Show resolved Hide resolved
src/services/db/GitFileSystemService.ts Outdated Show resolved Hide resolved
QiluXie
QiluXie reviewed Aug 15, 2023
View reviewed changes
src/services/db/GitFileSystemService.ts
const c = logFields as DefaultLogFields
return (
!!logFields &&
typeof logFields === "object" &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit & non-blocking: we should use c in line 43 & 44 instead of logFields since it was already casted to c in line 41

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do separately in a hotfix PR

QiluXie
QiluXie approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@QiluXie QiluXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dcshzj dcshzj force-pushed the IS-402-write-extend-repo-service-to-support-update-tree-and-update-repo-state-for-renames-and-moves branch from 2f88ef3 to 93abaf0 Compare August 15, 2023 10:22
@dcshzj dcshzj merged commit 031cb24 into develop Aug 15, 2023
@mergify mergify bot deleted the IS-402-write-extend-repo-service-to-support-update-tree-and-update-repo-state-for-renames-and-moves branch August 15, 2023 11:12
@dcshzj dcshzj mentioned this pull request Aug 16, 2023
Merged
2 tasks
@kishore03109 kishore03109 mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs left review comments

@QiluXie QiluXie QiluXie approved these changes

@harishv7 harishv7 harishv7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcshzj @harishv7 @QiluXie @alexanderleegs