Feat: add endpoint to check if user has access to site #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwajiehao
previously approved these changes
Dec 8, 2020
routes/sites.js
Outdated
| "Content-Type": "application/json", | ||
| } | ||
| }) | ||
| console.log(resp) |
There was a problem hiding this comment.
Can we remove this log statement?
There was a problem hiding this comment.
Whoops thanks for catch that, resolved in ba92d4b
Merged
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Feat: add endpoint to check if user has access to site * Fix: remove log statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new endpoint to check if users have access to a given site. To be reviewed in conjunction with PR#280 on the isomercms-frontend repo.
To check if a user has access to a site, we check if the user is one of the collaborators on that repo, and throw an error message if either the site does not exist or the user does not have the appropriate permissions. We have opted to throw the same 404 error in both of these cases.