Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authservice): update import #883

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix(authservice): update import #883

merged 1 commit into from
Aug 8, 2023

Conversation

seaerchin
Copy link
Contributor

Problem

previously, no .default added on import leading to errors (due to export default interaction wtih require)

Solution

add .default to require import

@seaerchin seaerchin requested a review from a team August 8, 2023 04:58
QiluXie
QiluXie approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@QiluXie QiluXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seaerchin seaerchin merged commit 5af5703 into develop Aug 8, 2023
@seaerchin seaerchin deleted the fix/upgrade-imports branch August 8, 2023 05:50
@alexanderleegs alexanderleegs mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QiluXie QiluXie QiluXie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @QiluXie