feat(siteLaunch): restrict to admin #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/services/infra/InfraService.ts
Outdated
Comment on lines
268
to
272
| const isAdmin = email.endsWith(".gov.sg") | ||
|
|
||
| if (!isAdmin) { | ||
| return errAsync(new SiteLaunchError("Not authorized to launch site")) | ||
| } |
There was a problem hiding this comment.
Just checking, is there a reason why we don't attach the checkIsSiteAdmin middleware to this instead (so checking for site admin, rather than just checking the email)
There was a problem hiding this comment.
O.o Derp moment
ae851f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No access controls for admins, can be reviewed with fe pr.
Solution
Only admins can call the BE route.